Skip to content

DPL: add RawDeviceService::waitFor method#4303

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:hide-fairmq
Sep 8, 2020
Merged

DPL: add RawDeviceService::waitFor method#4303
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:hide-fairmq

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Sep 8, 2020

This avoids exposing FairMQDevice.h to the user in a few more places.
Every inclusion of FairMQDevice.h results in 1GB of RAM and 2 seconds
of compilations in my naive tests.

@ktf ktf requested a review from a team as a code owner September 8, 2020 08:05
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Sep 8, 2020

@rbx @dennisklein is there any way we can avoid exposing boost::signals from FairMQDevice.h? It seems to add 2s and 1GB of RAM every time it's compiled.

This avoids exposing FairMQDevice.h to the user in a few more places.
Every inclusion of FairMQDevice.h results in 1GB of RAM and 2 seconds
of compilations in my naive tests.
@ktf ktf merged commit 2ec086d into AliceO2Group:dev Sep 8, 2020
@ktf ktf deleted the hide-fairmq branch September 8, 2020 11:03
@rbx
Copy link
Copy Markdown
Contributor

rbx commented Sep 8, 2020

@ktf i moved your question to a FairMQ issue.

arakotoz pushed a commit to arakotoz/AliceO2 that referenced this pull request Sep 26, 2020
This avoids exposing FairMQDevice.h to the user in a few more places.
Every inclusion of FairMQDevice.h results in 1GB of RAM and 2 seconds
of compilations in my naive tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants